Skip to content

lib: enable web worker api by default - #65323

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:web-worker-default-enable
Nov 11, 2026
Merged

lib: enable web worker api by default#65323
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:web-worker-default-enable

Conversation

@avivkeller

@avivkeller avivkeller commented Aug 16, 2026

Copy link
Copy Markdown
Member

cc @panva

Ref: #64894
Ref: #43583

Makes web worker support enabled by default

@avivkeller avivkeller added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues and PRs related to Node.js configuration and feature settings. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codecov

codecov Bot commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (5f602d5) to head (a90af6f).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65323      +/-   ##
==========================================
+ Coverage   90.68%   90.69%   +0.01%     
==========================================
  Files         797      797              
  Lines      279574   279574              
  Branches    53778    53778              
==========================================
+ Hits       253525   253561      +36     
+ Misses      16344    16302      -42     
- Partials     9705     9711       +6
Files with missing lines Coverage Δ
src/node_options.cc 88.20% <ø> (ø)
src/node_options.h 95.83% <100.00%> (+0.41%) ⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95
aduh95 reviewed Aug 17, 2026
View reviewed changes

@aduh95 aduh95 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to also add the changes entry and update the link at

node/doc/api/globals.md

Lines 1313 to 1320 in 8b9f89f

## Class: `Worker`
<!-- YAML
added: REPLACEME
-->
> Stability: 1 - Experimental. Enable this API with the
> [`--experimental-web-worker`][] CLI flag.

@avivkeller
avivkeller requested a review from aduh95 August 21, 2026 15:59
@panva panva added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 21, 2026
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 22, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 23, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76304/

@avivkeller
avivkeller force-pushed the web-worker-default-enable branch from 67ca30a to 1996a2a Compare August 24, 2026 05:11
@avivkeller
avivkeller requested a review from panva August 25, 2026 03:54
@avivkeller

avivkeller commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Needs a re-approval

aduh95
aduh95 reviewed Aug 25, 2026
View reviewed changes
Comment thread doc/api/globals.md Resolved
@aduh95

aduh95 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

We probably need a regression test

@panva panva removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 7, 2026
@avivkeller
lib: enable web worker api by default
a90af6f 
Signed-off-by: avivkeller <me@aviv.sh>
@avivkeller
avivkeller force-pushed the web-worker-default-enable branch from 1996a2a to cd6e15e Compare October 17, 2026 20:41
@lgarron

lgarron commented Oct 31, 2026

Copy link
Copy Markdown

We probably need a regression test

I've been meaning to try to build node to contribute some regression tests based on this comment, but the tests look like they have reasonable coverage already. Is there any particular functionality that needs a regression test that doesn't already have it?

@panva
panva force-pushed the web-worker-default-enable branch from cd6e15e to a90af6f Compare November 8, 2026 11:25
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 8, 2026
@panva
panva requested a review from a team November 8, 2026 11:26
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78907/

gurgunday
gurgunday approved these changes Nov 10, 2026
View reviewed changes

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Nov 11, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

does it emit an experimental warning on fist use?

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 11, 2026
@panva

panva commented Nov 11, 2026

Copy link
Copy Markdown
Member

does it emit an experimental warning on fist use?

no, can be done in a followup if there's appetite for it.

@nodejs-github-bot
nodejs-github-bot merged commit 77e6379 into nodejs:main Nov 11, 2026
68 checks passed
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Landed in 77e6379

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 11, 2026
@panva panva added the experimental Issues and PRs related to experimental features. label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@mcollina mcollina mcollina approved these changes
@panva panva panva approved these changes
@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. config Issues and PRs related to Node.js configuration and feature settings. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@avivkeller @nodejs-github-bot @aduh95 @lgarron @panva @mcollina @gurgunday